Changeset 680 for trunk

Timestamp:

12/15/09 13:08:42 (2 years ago)

Author:

nate

Message:

• Fixed an error that would cause an infinite loop.

Files:

• trunk/phpbms/modules/mailchimp/include/list_sync.php (modified) (3 diffs)

trunk/phpbms/modules/mailchimp/include/list_sync.php

@@ -115 +115 @@
         
         $tempArray["message"] = $message;
-        if($errorCode !== NULL)
-            $tempArray["code"] = $errorCode;
+        $tempArray["code"] = $errorCode;
         
         $this->errors[] = $tempArray;
@@ -276 +275 @@
           *  pull all the subscribed 
           */
+        $i = 0;
         do{    
             $valuesClause = "";
             
-            $members = $this->api->listMembers($this->listId, 'subscribed', NULL, 0, $this->batchLimit);
+            $members = $this->api->listMembers($this->listId, 'subscribed', NULL, $i*$this->batchLimit, $this->batchLimit*($i+1));
 
             if($this->api->errorCode){
@@ -294 +294 @@
               *  Put the subscribed into a temporary table 
               */
-            $insertStatement = "
-                INSERT INTO
-                    `tempEmail`
-                (`email`)
-                    VALUES
-                ".$valuesClause;
-            
-            $this->db->query($insertStatement);
-            
+            if($valuesClause){
+                $insertStatement = "
+                    INSERT INTO
+                        `tempEmail`
+                    (`email`)
+                        VALUES
+                    ".$valuesClause;
+                
+                $this->db->query($insertStatement);
+            }//end if
+            
+            $i++;
         }while(count($members) == $this->batchLimit);