Changeset 704 for trunk/phpbms/modules/base/notes_records.php

Timestamp:

01/01/10 23:10:02 (2 years ago)

Author:

brieb

Message:

• Fixed several SQL injection vulnerabilities
• Fixed several XSS vulnerabilities due to PHP_SELF and REQUREST_URI
• Fixed severa path disclosure errors

Files:

• trunk/phpbms/modules/base/notes_records.php (modified) (3 diffs)

trunk/phpbms/modules/base/notes_records.php

@@ -70 +70 @@
         if(!isset($_POST["newsort"])) $_POST["newsort"]="";
         if(!isset($_POST["desc"])) $_POST["desc"]="";
-        
+
 
         if($_POST["newsort"]!="") {
@@ -81 +81 @@
 
         if($displayTable->querytype!="new" and $displayTable->querytype!="edit") {
-                
+
         //record offset?
         if(isset($_POST["offset"])) if($_POST["offset"]!="") $displayTable->recordoffset=$_POST["offset"];
@@ -96 +96 @@
         <h1><?php echo $pageTitle ?></h1>
         <div>
-                <form name="search" id="search" action="<?php echo $_SERVER["REQUEST_URI"]?>" method="post" onsubmit="setSelIDs(this);return true;">
+                <form name="search" id="search" action="<?php echo htmlentities($_SERVER["REQUEST_URI"])?>" method="post" onsubmit="setSelIDs(this);return true;">
                 <input name="theids" type="hidden" value="" />
                 <?php