Changeset 704 for trunk/phpbms/modules/bms/products_addedit.php

Timestamp:

01/01/10 23:10:02 (2 years ago)

Author:

brieb

Message:

• Fixed several SQL injection vulnerabilities
• Fixed several XSS vulnerabilities due to PHP_SELF and REQUREST_URI
• Fixed severa path disclosure errors

Files:

• trunk/phpbms/modules/bms/products_addedit.php (modified) (3 diffs)

trunk/phpbms/modules/bms/products_addedit.php

@@ -145 +145 @@
         include("header.php");
 ?>
-<form action="<?php echo str_replace("&","&amp;",$_SERVER["REQUEST_URI"]) ?>" method="post" enctype="multipart/form-data" name="record" id="record" onsubmit="return false;">
+<form action="<?php echo htmlentities($_SERVER["REQUEST_URI"]) ?>" method="post" enctype="multipart/form-data" name="record" id="record" onsubmit="return false;">
 <?php $phpbms->showTabs("products entry","tab:17346362-261b-4d1d-fa77-99e84cfd9b8a",$therecord["id"]);?><div class="bodyline">
         <input type="hidden" value="" name="command" id="hiddenCommand"/>
@@ -273 +273 @@
                                         thumbnail graphic<br />
                                         <?php if($therecord["thumbnailmime"]) {?>
-                                                <img id="thumbpic" src="<?php echo APP_PATH ?>dbgraphic.php?t=products&f=thumbnail&mf=thumbnailmime&r=<?php echo $therecord["id"]?>" style="border: 1px solid black; display: block; margin: 3px;;" />
+                                                <img id="thumbpic" src="<?php echo APP_PATH ?>dbgraphic.php?t=productThumb&r=<?php echo $therecord["id"]?>" style="border: 1px solid black; display: block; margin: 3px;;" />
                                         <?php } else {?>
                                                 <div id="noThumb" class="tiny" align="center">no thumbnail</div>
@@ -286 +286 @@
                                         main picture<br />
                                         <?php if($therecord["picturemime"]) {?>
-                                                <img id="picturepic" src="<?php echo APP_PATH ?>dbgraphic.php?t=products&f=picture&mf=picturemime&r=<?php echo $therecord["id"]?>" style="border: 1px solid black; display: block; margin: 3px;;" />
+                                                <img id="picturepic" src="<?php echo APP_PATH ?>dbgraphic.php?t=productPic&r=<?php echo $therecord["id"]?>" style="border: 1px solid black; display: block; margin: 3px;;" />
                                         <?php } else {?>
                                                 <div id="noPicture" class="tiny" align="center">no picture</div>