Changeset 728 for trunk/phpbms/include

Timestamp:

01/07/10 12:45:17 (2 years ago)

Author:

brieb

Message:

• Fixed possible security loopholes in search screen (SQL Manipulation)

Location:

trunk/phpbms/include

Files:

• relationships.php (modified) (1 diff)
• search_class.php (modified) (1 diff)

trunk/phpbms/include/relationships.php

@@ -102 +102 @@
         */
         foreach($theids as $theid)
-            $_SESSION["passedjoinwhere"] .= " OR ".$therecord["fromtable"].".id = ".$theid;
+            $_SESSION["passedjoinwhere"] .= " OR ".$therecord["fromtable"].".id = ".((int) $theid);
 
         $_SESSION["passedjoinwhere"] = substr($_SESSION["passedjoinwhere"], 3);

trunk/phpbms/include/search_class.php

@@ -81 +81 @@
                                         searchroleid,
                                         advsearchroleid,
-                                        viewsqlroleid
+                                        viewsqlroleid,
+                                        editroleid,
+                                        addroleid
                                 FROM
-                                        tabledefs inner join modules on tabledefs.moduleid = modules.uuid
+                                        tabledefs INNER JOIN modules on tabledefs.moduleid = modules.uuid
                                 WHERE
                                         tabledefs.uuid= '".$id."'";