phpBMS

Ticket #22 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

duplicating backslahes on update with quotes in admins settings page

Reported by: jceh Owned by: jceh
Priority: minor Milestone: 0.62
Component: phpbms Version: 0.61
Keywords: Cc:

Description

On the admins screen, under the settings tab, If you add quotes to any of the fields (application name, company name, address, etc...), a backslash will be added next to it when you press the 'Update Settings' button. The backslashes will continue to double in the field if you keep updating the page. The header where the application name is displayed will also show the backslashes.

Attachments

adminsettings_patch.diff Download (1.9 KB) - added by jceh 5 years ago.
adminsettings_include_patch.diff Download (0.7 KB) - added by jceh 5 years ago.
fields_patch.diff Download (1.1 KB) - added by jceh 5 years ago.
menu_patches.diff Download (1.0 KB) - added by jceh 5 years ago.

Change History

Changed 5 years ago by jceh

adding stripslashes when displaying and addslashes when inserting fixs the issue.

Changed 5 years ago by jceh

Changed 5 years ago by jceh

Changed 5 years ago by jceh

Changed 5 years ago by jceh

Changed 5 years ago by brieb

Here's the problem... I think. The database is actually being updated correctly, but when it comes back from updating what it is displaying is the updated session variables, which need to be de-slashed... buut only if magicquotes is... on(or maybe off).

Changed 5 years ago by brieb

You can test this ny updating, let's say the address with a double-quote.. When it comes back to the admin screen you will that nasty slash, but if you immediately log out and back log in, the admin screen is all good.

What this means is that only the current session is getting those yucky slashes.

Another thing to test is to see what the results are with magicquotes turned back on (or off) and see if the is a deviation in the results.

Changed 5 years ago by brieb

  • keywords review added

Changed 5 years ago by brieb

  • status changed from new to closed
  • resolution set to fixed

Fixed with changeset [97]. Just needed to stripsalashes when setting the updated settings in the session.

Changed 5 years ago by brieb

  • keywords review removed
Note: See TracTickets for help on using tickets.
Scanned by Orvant Copyright © 2010 Kreotek, LLC. All Rights reserved.