Add support for jpg format images for reports logo

[ZGAnderson]

phpBMS currently allows very specifically formatted png images for report logos. Would be nice to be able to use the more common jpg format. The fpdf/mem_image library supports both filetypes.

[brieb]

More information can be attained here:

 http://phpbms.org/forum/viewtopic.php?t=13

This should be fairly trivial... Anyone want to submit a diff?

[ZGAnderson]

Hey, I've got this updated and working with the db type check. The update was made in the four invoices_pdf files as well as some text changes to the admin settings file.

I'm new to php, this is my first programming work with it. So while the code works, I'm not sure 100% on the various conventions and such.

Also, what diff tool do you prefer? How should I submit it?

[mipalmer]

The normal 'diff' command is fine from *nix. Generally you also get the same functionality out of most IDE's. (I use eclipse/phpeclipse/subclipse so I just have a "create patch" option.) Then you just attach the .diff files to this ticket.

But if you can't figure it out, just attach the files to this ticket and I will work out the diffs myself.

Thanks

[brieb]

Good work.

Since your diff was not with the latest from the trunk, I paraphrased your code. Also, there was no need to issue a second query, only to grab the type, so I rolled it into the above query.

Also, when submitting diffs, try having the file names like pdfinvoices.diff or pdfinvoicesphp.diff, so that trac can show the diff in all it's glory!

[mipalmer]

Thanks ZGAnderson!

It looks like the problem with trac is something I should have told you about. The diff command has 3 different formats. It looks like you did "normal format" and we do this in whats called "context format" due to human readability. The difference between how you did it and context format is using the context flag "diff -c file newfile"

If your interested,  http://en.wikipedia.org/wiki/Diff

Anyways, thanks again and great work! I'm sure other bms users will benifit from your effort!

-Mike

[ZGAnderson]

I've added a diff (looks like I got the diff command right this time!) which includes the update that I've tested to work with JPEG. I don't think the current trunk works right.