credit doesnt deduct from client view page

[irefuse]

hello,

when you go to view a client and click the credit tab, it does not show the open AR items and deduct the amount from the available credit. Although when you go to create a new invoice under the client's credit, it shows the proper available credit.

[irefuse]

arlist

[irefuse]

client credit tab

[irefuse]

i know what the problem is and im going to look for a logical way to fix it. if someone else has an update before i find out let me know. it has to do with the showHistory() function. when executed in the modules/bms/clients_credit.php file it pulls the old "id" but the function compares that to the "clientid" of aritems table which is using the new uuid system

[irefuse]

*update* although i still do not know what is causing the issue with the credit remaining section to not be updated...

[irefuse]

patch file for modules/bms/clients_credit.php

[irefuse]

patch file for modules/bms/include/clients_credit.php

[irefuse]

i have found a solution that makes my bms work. the mods may want to take a look at it and verify it and make changes of their own. but this solution does work for me.

[irefuse]

*note* these patches also fix the issue of the remaining credit not updating.

[irefuse]

*new* fix. this one corrects an issue with displaying all user's credit usage in the "Open Items" area

[rthconsultants@…]

As well, the 'credit left' field doesn't refelect proper calculation of open AR items. I have started to debug this issue.

In /modules/bms/clients_credit.php "$therecordcreditlimit?-$therecordoutstanding?" (LN:79) should correctly calculate the credit available (less the open AR items). After viewing the $therecord stack, it doesn't contain an element called, 'outstanding'. Therefore the calculation is always "creditlimit-0".

The $therecord array is populated by this class/method: $clientCredit->get()

I haven't located that class method yet to continue reverse engineering the issue. Hope this helps!

[dsterry/weex]

I ran across this problem without knowing there was a bug report here and code to boot. I fixed it with  https://github.com/weex/phpBMS/commit/8012f5f92e2aaa108cfce8c72afb09be28b2eeef